Rescue NonExistingDocumentError in base server
#2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
st0012
approved these changes
Jul 18, 2024
|
Should there be a test case for this though? Otherwise it'll be hard to tell if/when we'll need this in the future. |
andyw8
reviewed
Jul 18, 2024
vinistock
force-pushed
the
vs/rescue_non_existing_document_error
branch
from
4dd4873
to
229b4e9
Compare
Added a test. Note that it has to be an integration test because the only way to reach the code path where we rescue is by reading the request from STDIN. |
andyw8
approved these changes
Jul 18, 2024
st0012
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #2313, I forgot that we need to rescue the new
NonExistingDocumentErrorin base server, otherwise the TypeScript client tests will fail when VS Code opens some fake files automatically.Implementation
Added the missing rescue.