Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No type hints on projects with sorbet when the sorbet extension is not installed #2383

Closed
Earlopain opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Earlopain
Copy link
Contributor

Description

I noticed that while things seem to be getting indexed I'm not getting any completions for this repo at all and eventually found out that that is because I was missing the sorbet extension. I'd guess this is because of this? #2322

After installation I got hints back. Does it make sense to check for extension presence (this maybe https://code.visualstudio.com/api/references/vscode-api#extensions.getExtension) and provide better behavior for users without it installed?

@Earlopain Earlopain added the bug Something isn't working label Jul 30, 2024
@andyw8 andyw8 removed their assignment Aug 1, 2024
@vinistock
Copy link
Member

Thank you for the suggestion! We plan to have more in depth integrations with Sorbet, so hopefully this issue will be solved as a consequence of that.

That said, at the current moment, the Ruby LSP doesn't interact with Sorbet in any way, so we found it a bit odd to have a check verifying if the extension is there. What I mean is, Sorbet is not required for the Ruby LSP to work and yet we'd essentially be adding Sorbet specific functionality.

@vinistock vinistock closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants