Refactor index to nest declarations inside entries #1950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
breaking-change
vinistock
changed the title
vinistock
force-pushed
the
vs/split_constant_and_method_entries
branch
from
38327f4
to
d114d41
Compare
vinistock
force-pushed
the
vs/split_constant_and_method_entries
branch
from
d114d41
to
e8642f5
Compare
vinistock
force-pushed
the
vs/refactor_entries
branch
from
01f450c
to
7063dcc
Compare
vinistock
force-pushed
the
vs/split_constant_and_method_entries
branch
from
e8642f5
to
5746b68
Compare
vinistock
force-pushed
the
vs/refactor_entries
branch
from
7063dcc
to
d37657a
Compare
vinistock
force-pushed
the
vs/split_constant_and_method_entries
branch
from
5746b68
to
9ef56fc
Compare
vinistock
force-pushed
the
vs/refactor_entries
branch
from
d37657a
to
fe4e400
Compare
|
We decided to drop this approach and go with #2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Do not review. Will fill details soon.
Implementation
Automated Tests
Manual Tests