Improve client integration tests #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
approved these changes
May 10, 2024
lib/core_ext/uri.rb
Outdated
| @@ -11,6 +11,9 @@ def from_path(path:, fragment: nil, scheme: "file") | |||
| # On Windows, if the path begins with the disk name, we need to add a leading slash to make it a valid URI | |||
| escaped_path = if /^[A-Z]:/i.match?(path) | |||
| DEFAULT_PARSER.escape("/#{path}") | |||
| elsif path.start_with?("//?/") | |||
| # Some paths on Windows start with "//?/". This is a special prefix that allows for long file paths | |||
vinistock
force-pushed
the
vs/improve_client_integration_tests
branch
from
35f66a8
to
c979ae7
Compare
andyw8
pushed a commit
that referenced
this pull request
May 29, 2024
* Ensure RubyInstaller is retrieving the right PATH * Improve integration tests to activate the current Ruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on #2017, I realized that our client integration test was not activating Ruby (it just used the one available on CI), which was actually masking some issues.
This PR improves our tests and fixes the related issues to make tests pass.
Implementation
The PR is split by commit:
Pathinstead ofPATH, which was causing us to miss the general environment on the RubyInstaller integrationAutomated Tests
Added tests.