vscode/asdf: search the default XDG base data directory #2045
Conversation
| @@ -51,8 +51,19 @@ export class Asdf extends VersionManager { | |||
| // file, but that may not be the case for a Homebrew installation, in which case the we'd have | |||
| // `/opt/homebrew/opt/asdf/libexec/asdf.sh`, but the data directory might be `~/.asdf` | |||
| async findAsdfDataDir(): Promise<vscode.Uri> { | |||
| // In order, the data locations are: | |||
| // 1. Default | |||
There was a problem hiding this comment.
(nit) If we assign each possible path to a variable, then we could avoid the need for this comment.
There was a problem hiding this comment.
Yeah. I copied this from the other method, but it can easily be removed if not helpful.
|
(the rest of the team is at RubyKaigi so there might be a little delay until we ship this) |
This updates the detection of the asdf data directory for setting the environment variable `ASDF_DATA_DIR` during activation. Fixes #2023
|
Just bumping this and wondering if the tests could be run so that this is ready to go when reviewed and if approved. |
|
Triggered the tests. |
|
@gi I shipped a few improvements to the ASDF implementation which should fix many of the issues we were seeing before. I think this PR can just add the |
|
@vinistock I just tested the latest version, and the changes work on my machine. Thanks for updating. I'm going to close this as the changes are no longer needed. The issue was fixed by #2006 |
This updates the detection of the asdf data directory for setting the environment variable
ASDF_DATA_DIRduring activation.Fixes #2023
Motivation
Fixes #2023
The XDG base directory specification is becoming more popular in outside of Linux. The default base data directory is
~/.local/sharewhere applications store their user data within a directory under the base: e.g.~/.local/share/asdf.Implementation
This update includes the XDG base data directory in the list when detecting the location for activation.
Automated Tests
Yes.
Manual Tests
~/.local/share/asdf/shims