Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable highlightUntyped #2100

Merged
merged 1 commit into from
May 29, 2024
Merged

Disable highlightUntyped #2100

merged 1 commit into from
May 29, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented May 29, 2024 •
edited
Loading

As agreed with @vinistock, we were finding it too distracting.

@andyw8 andyw8 added server This pull request should be included in the server gem's release notes chore Chore task Severity: 2 High Severity vscode This pull request should be included in the VS Code extension's release notes and removed server This pull request should be included in the server gem's release notes labels May 29, 2024
@andyw8 andyw8 marked this pull request as ready for review May 29, 2024 17:28
@andyw8 andyw8 requested a review from a team as a code owner May 29, 2024 17:28
@andyw8 andyw8 requested review from st0012 and vinistock May 29, 2024 17:28
@andyw8 andyw8 merged commit ab7b269 into main May 29, 2024
37 of 38 checks passed
@andyw8 andyw8 deleted the andyw8/disable-highlightUntyped branch May 29, 2024 17:29
andyw8 added a commit that referenced this pull request May 29, 2024
@andyw8
Disable highlightUntyped (#2100)
ade5b1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morriar Morriar Morriar approved these changes

@st0012 st0012 Awaiting requested review from st0012 st0012 is a code owner automatically assigned from Shopify/ruby-dx

@vinistock vinistock Awaiting requested review from vinistock vinistock is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
chore Chore task Severity: 2 High Severity vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @Morriar