Push singleton context when inside singleton method #2189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses the bug identified in #2188.
When we enter a singleton method defined with
def self.
, we need to push a singleton context to our stacks or else we will record incorrect owners for anything defined inside of it.Implementation
Started pushing to the stacks when we enter a singleton method and popping when we are leaving.
Automated Tests
Added a test that demonstrates the issue.