Push singleton context when inside singleton method #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Morriar
reviewed
Jun 14, 2024
| def test_class_instance_variables_inside_self_method | ||
| index(<<~RUBY) | ||
| class Foo | ||
| def self.bar |
There was a problem hiding this comment.
Should we check that the receiver is self on the def?
Consider this:
class Bar
def Foo.bar; end
endThere was a problem hiding this comment.
We do check that when entering the singleton context. I added a test to demonstrate the current behaviour (which is to associate the instance variable with the owner owner since we can't process dynamic def something.bar declarations.
andyw8
approved these changes
Jun 17, 2024
vinistock
force-pushed
the
vs/fix_class_ivar_indexing
branch
from
6351d31
to
2f1cc88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses the bug identified in #2188.
When we enter a singleton method defined with
def self., we need to push a singleton context to our stacks or else we will record incorrect owners for anything defined inside of it.Implementation
Started pushing to the stacks when we enter a singleton method and popping when we are leaving.
Automated Tests
Added a test that demonstrates the issue.