-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push singleton context when inside singleton method #2189
Merged
+46
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule prism
updated
29 files
+2 −2 | .github/workflows/main.yml | |
+4 −4 | Gemfile.lock | |
+0 −103 | config.yml | |
+0 −1 | docs/serialization.md | |
+1 −8 | ext/prism/extension.c | |
+3 −3 | gemfiles/3.0/Gemfile.lock | |
+3 −3 | gemfiles/3.1/Gemfile.lock | |
+3 −3 | gemfiles/3.2/Gemfile.lock | |
+3 −3 | gemfiles/3.3/Gemfile.lock | |
+3 −3 | gemfiles/3.4/Gemfile.lock | |
+16 −15 | gemfiles/typecheck/Gemfile.lock | |
+0 −15 | include/prism/options.h | |
+0 −11 | include/prism/parser.h | |
+0 −2 | java-wasm/src/test/java/org/prism/DummyTest.java | |
+1 −6 | java/org/prism/ParsingOptions.java | |
+0 −3 | javascript/src/parsePrism.js | |
+0 −3 | lib/prism/ffi.rb | |
+3 −3 | lib/prism/translation/parser.rb | |
+1 −1 | lib/prism/translation/parser/lexer.rb | |
+0 −2 | rakelib/typecheck.rake | |
+16 −16 | rbi/prism.rbi | |
+0 −9 | src/options.c | |
+194 −143 | src/prism.c | |
+1 −3 | templates/src/diagnostic.c.erb | |
+4 −4 | test/prism/errors_test.rb | |
+0 −4 | test/prism/fixtures/break.txt | |
+0 −59 | test/prism/result/implicit_array_test.rb | |
+5 −10 | test/prism/ruby/parser_test.rb | |
+55 −101 | test/prism/snapshots/break.txt |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check that the receiver is
self
on the def?Consider this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do check that when entering the singleton context. I added a test to demonstrate the current behaviour (which is to associate the instance variable with the owner owner since we can't process dynamic
def something.bar
declarations.