Allow turning off ERB support through setting #2311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2282
If the user is working on a project with a dependency that prevents the Ruby LSP server from upgrading, the server will not have ERB support.
Unfortunately, mutating the document selector after the client has already launched doesn't stop it from receiving requests for the removed language IDs. And we have no way of knowing if the server version supports ERB before actually launching. It's a chicken and egg problem.
Implementation
I believe the best we can do is the following (implemented in this PR):
Concerns
Should we even do this? This means that anyone on old server versions will always need to boot the server twice until they manage to upgrade to newer versions.