Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show file operations in the explorer view #2321

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

vinistock
Copy link
Member

Motivation

There was a mistake in our when clause for the file operations button. The way to associate a button with a specific view is to check for the view ID (see view in the when clause docs).

Implementation

Changed the view/title contribution to only add the button in the explorer view. The button was appearing in all views, including terminal, output, debug console. Now, it only shows up in the explorer view.

Additionally, there's no need for additional checks for the menu item, because that one is specifically added to the explorer/context, which only shows up in the explorer view.

@vinistock vinistock added bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes labels Jul 18, 2024
@vinistock vinistock self-assigned this Jul 18, 2024
@vinistock vinistock requested a review from a team as a code owner July 18, 2024 13:33
@vinistock vinistock requested review from andyw8 and st0012 July 18, 2024 13:33
@vinistock vinistock merged commit abdeb38 into main Jul 18, 2024
35 checks passed
@vinistock vinistock deleted the vs/fix_file_op_when_clauses branch July 18, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants