Handle Sorbet levels to prevent some feature duplication #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
vinistock
commented
Jul 18, 2024
|
🤔 Will any of the signature changes here impact addons? |
It shouldn't, we weren't passing |
st0012
reviewed
Jul 19, 2024
vinistock
force-pushed
the
vs/handle_sorbet_levels
branch
from
df911f3
to
6a96430
Compare
|
I dug a little deeper and there were a few other scenarios I hadn't realized. For example, Sorbet can provide constant completion even if a file has no The PR should be good for another round of reviews. |
st0012
approved these changes
Jul 22, 2024
andyw8
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is a step towards #2294
We added a bunch of new features recently, but we weren't super careful about checking which parts overlapped with Sorbet's behaviour and under which scenarios. This resulted in a bit of duplicate behaviour and we can improve that.
Note that full removal of any kind of duplication is going to require deep integration with the type checker and is a much more involved effort.
Implementation
Essentially, requests have to know the level of Sorbet type checking available for a file to make decisions about what to provide.
Instead of trying to use a blanket statement like
typechecker_enabled?, I switched to passing the Sorbet level of type checking to the relevant requests.I left some comments on the PR to help understand the decisions.
Automated Tests
Added tests.