Raise explicit NonExistingDocumentError for unseen untitled files #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
approved these changes
Jul 19, 2024
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Aug 3, 2024
These are expected to happen. VSCode extensions can registers additional uri schemes for which they provide content for. These do not exist on disk which means the server will not find them in the index. Happens since Shopify#2334 Also adds a test that virtual documents raise the same error https://code.visualstudio.com/api/extension-guides/virtual-documents https://code.visualstudio.com/api/references/document-selector#document-scheme Closes Shopify#2384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm not exactly sure what order of operations is required to trigger this problem, but based on our telemetry it seems to be possible to receive a request for an unsaved file before we received a
didOpennotification for it.Since the file is unsaved, we cannot try to read it from disk and there's no path associated to it.
Implementation
Started checking if
pathexists. If we never saw the document before (it's not in the store) and there's nopath, then we have no hope of figuring out what the document contains. We can only raise.Automated Tests
Added a test reproducing the issue.