Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename constant alias class names #2361

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 24, 2024

Motivation

This is to match MethodAlias and UnresolvedMethodAlias.

Implementation

  • Alias should be ConstantAlias
  • UnresolvedAlias should be UnresolvedConstantAlias

Automated Tests

Manual Tests

- Alias should be ConstantAlias
- UnresolvedAlias should be UnresolvedConstantAlias

This is to match MethodAlias and UnresolvedMethodAlias.
@st0012 st0012 added chore Chore task server This pull request should be included in the server gem's release notes labels Jul 24, 2024
@st0012 st0012 self-assigned this Jul 24, 2024
@st0012 st0012 requested a review from a team as a code owner July 24, 2024 22:06
@st0012 st0012 requested review from andyw8 and vinistock July 24, 2024 22:06
@st0012 st0012 merged commit b1f677f into main Jul 25, 2024
37 checks passed
@st0012 st0012 deleted the rename-constant-alias-entries branch July 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants