Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for indexing troubleshooting #2367

Closed
wants to merge 3 commits into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Jul 25, 2024

Closes #2296

@andyw8 andyw8 added documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes labels Jul 25, 2024
@andyw8 andyw8 requested a review from a team as a code owner July 25, 2024 19:45
@andyw8 andyw8 requested review from st0012 and vinistock July 25, 2024 19:45
@andyw8 andyw8 force-pushed the andyw8/document-indexing-troubleshooting branch from 93febef to 2a4b5e5 Compare July 25, 2024 19:46
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link to this new section from the indexing error dialog

send_message(Notification.window_show_error("Error while indexing: #{error.message}"))
.

TROUBLESHOOTING.md Outdated Show resolved Hide resolved

When Ruby LSP starts, it attempts to index your code as well as your dependencies as described in [Configuring code indexing](README.md#configuring-code-indexing).

In rare cases, Ruby LSP will encounter an error which prevents parsing from completing, meaning Ruby LSP cannot start.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We rescue all indexing errors, so that the language server doesn't crash. The only consequence of an indexing failure is incomplete indexing data.

Suggested change
In rare cases, Ruby LSP will encounter an error which prevents parsing from completing, meaning Ruby LSP cannot start.
In rare cases, Ruby LSP will encounter an error which prevents indexing from completing, which will result in incomplete information in the editor.

TROUBLESHOOTING.md Outdated Show resolved Hide resolved
andyw8 and others added 2 commits July 25, 2024 16:35
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
Co-authored-by: Stan Lo <stan001212@gmail.com>
Copy link
Contributor

This pull request is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Sep 24, 2024
@andyw8
Copy link
Contributor Author

andyw8 commented Sep 30, 2024

Since the new docs have been moved around, I'll close this and open a seperate PR.

@andyw8 andyw8 closed this Sep 30, 2024
@andyw8 andyw8 reopened this Sep 30, 2024
@andyw8 andyw8 closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation server This pull request should be included in the server gem's release notes Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help users diagnose indexing issues
3 participants