Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using stubs in test_helper.rb as it depends on Mocha #2474

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Avoid using stubs in test_helper.rb as it depends on Mocha #2474

merged 1 commit into from
Aug 21, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 21, 2024

Motivation

Closes #2190

Implementation

Simply update the global state when stub_no_typechecker is set to true.

Automated Tests

Manual Tests

@st0012 st0012 added bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes labels Aug 21, 2024
@st0012 st0012 self-assigned this Aug 21, 2024
@st0012 st0012 requested a review from a team as a code owner August 21, 2024 16:21
@st0012 st0012 merged commit ac0b1e6 into main Aug 21, 2024
35 checks passed
@st0012 st0012 deleted the fix-#2190 branch August 21, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@vinistock vinistock Awaiting requested review from vinistock vinistock is a code owner automatically assigned from Shopify/ruby-dx

Assignees

@st0012 st0012

Labels
bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with_server helper should not use stubs for the stub_no_typechecker option
2 participants
@st0012 @andyw8