Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sorbet when setting up bundle #821

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

vinistock
Copy link
Member

Motivation

We need to require sorbet-runtime here because setting up the bundler happens before our regular require.

Also bumped the version to fix the v0.7.1 which is broken.

@vinistock vinistock added the bugfix This PR will fix an existing bug label Jul 18, 2023
@vinistock vinistock added this to the 2023-Q3 milestone Jul 18, 2023
@vinistock vinistock self-assigned this Jul 18, 2023
@vinistock vinistock requested a review from a team as a code owner July 18, 2023 15:56
@vinistock vinistock requested review from Morriar and st0012 July 18, 2023 15:56
@vinistock vinistock enabled auto-merge July 18, 2023 15:59
@vinistock vinistock merged commit 2c2d029 into main Jul 18, 2023
25 checks passed
@vinistock vinistock deleted the vs/require_sorbet_when_setting_up_bundle branch July 18, 2023 16:00
@github-actions
Copy link
Contributor

Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.264764 std_dev: 0.005162
          textDocument/diagnostic average: 0.041654 std_dev: 0.009423
          textDocument/definition average: 0.004681 std_dev: 0.003072
      textDocument/selectionRange average: 0.003542 std_dev: 0.000483
   textDocument/documentHighlight average: 0.001812 std_dev: 0.000129
 textDocument/semanticTokens/full average: 0.001745 std_dev: 0.000281
            textDocument/codeLens average: 0.001734 std_dev: 0.000165
        textDocument/documentLink average: 0.001724 std_dev: 0.000104
      textDocument/documentSymbol average: 0.001721 std_dev: 9.2e-05
        textDocument/foldingRange average: 0.001604 std_dev: 0.000117
textDocument/semanticTokens/range average: 0.000873 std_dev: 5.5e-05
               codeAction/resolve average: 0.000647 std_dev: 6.6e-05
               textDocument/hover average: 0.000608 std_dev: 6.9e-05
           textDocument/inlayHint average: 0.0006 std_dev: 4.5e-05
          textDocument/formatting average: 6.9e-05 std_dev: 0.000299
    textDocument/onTypeFormatting average: 6.8e-05 std_dev: 4.2e-05
          textDocument/codeAction average: 3.9e-05 std_dev: 2.7e-05


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
      textDocument/documentSymbol unchanged
        textDocument/foldingRange unchanged
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve unchanged
          textDocument/completion unchanged
            textDocument/codeLens unchanged
          textDocument/definition unchanged


================================================================================
Missing benchmarks:

RubyLsp::Requests::ShowSyntaxTree

@shopify-shipit shopify-shipit bot temporarily deployed to production July 18, 2023 16:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants