-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use URI objects instead of strings #848
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/use_uri_objects
branch
2 times, most recently
from
August 2, 2023 17:03
2683c8a
to
7944c78
Compare
andyw8
reviewed
Aug 2, 2023
andyw8
reviewed
Aug 2, 2023
andyw8
approved these changes
Aug 2, 2023
|
bitwise-aiden
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that it is better to do this now than to push it off. Especially if we feel like more extensions will onboard down the path.
vinistock
force-pushed
the
vs/use_uri_objects
branch
from
August 3, 2023 13:37
7944c78
to
1ad1b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #709
Closes #781
Representing URIs with strings is incorrect. We should always rely on
URI
to get the correct file paths and further we delay this change, the more entangled it might become.There are already two issues related to this: not handling spaces properly and being unable to support unsaved files (#633).
Implementation
The most important changes are in
Store
andExecutor
. Everything else is pretty much just adapting the types fromString
toURI::Generic
.One thing to note is that for unsaved files the URI is
untitled:Untitled-1
, which has path asnil
anopaque
as the filename (Untitled-1
).This is a breaking change because extensions will no longer receive a URI string, but a URI object instead.
Automated Tests
Adapted all tests to use URI objects.