Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expectation for namespaced hover #941

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Aug 28, 2023

Motivation

To help ensure the current behaviour is preserved when migrating to YARP.

Implementation

New fixture and expectation.

Automated Tests

n/a

Manual Tests

n/a

@andyw8 andyw8 requested a review from a team as a code owner August 28, 2023 19:48
@andyw8 andyw8 added the chore Chore task label Aug 28, 2023
@andyw8 andyw8 merged commit e4f0967 into main Aug 28, 2023
31 checks passed
@andyw8 andyw8 deleted the andyw8/add-expectation-for-namespaced-hover branch August 28, 2023 19:57
@github-actions
Copy link
Contributor

Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.201887 std_dev: 0.00347
          textDocument/diagnostic average: 0.042441 std_dev: 0.009766
          textDocument/definition average: 0.004852 std_dev: 0.002911
      textDocument/selectionRange average: 0.004254 std_dev: 0.000528
   textDocument/documentHighlight average: 0.002629 std_dev: 0.000209
 textDocument/semanticTokens/full average: 0.002554 std_dev: 0.000182
            textDocument/codeLens average: 0.002553 std_dev: 0.00021
        textDocument/documentLink average: 0.002545 std_dev: 0.000216
      textDocument/documentSymbol average: 0.002529 std_dev: 0.00022
        textDocument/foldingRange average: 0.002491 std_dev: 0.000246
textDocument/semanticTokens/range average: 0.001684 std_dev: 0.000173
               codeAction/resolve average: 0.001461 std_dev: 0.000103
           textDocument/inlayHint average: 0.001418 std_dev: 7.4e-05
               textDocument/hover average: 0.001403 std_dev: 9.7e-05
          textDocument/formatting average: 0.000873 std_dev: 0.000296
    textDocument/onTypeFormatting average: 0.000858 std_dev: 8.7e-05
          textDocument/codeAction average: 0.000827 std_dev: 0.000102


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full unchanged
textDocument/semanticTokens/range unchanged
      textDocument/documentSymbol unchanged
        textDocument/foldingRange unchanged
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink unchanged
           textDocument/inlayHint unchanged
      textDocument/selectionRange unchanged
   textDocument/documentHighlight unchanged
               textDocument/hover unchanged
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve unchanged
          textDocument/completion unchanged
            textDocument/codeLens unchanged
          textDocument/definition unchanged


================================================================================
Missing benchmarks:

RubyLsp::Requests::ShowSyntaxTree

vinistock added a commit that referenced this pull request Feb 28, 2024
* Bump @shopify/eslint-plugin from 43.0.0 to 44.0.0

Bumps [@shopify/eslint-plugin](https://github.com/Shopify/web-configs/tree/HEAD/packages/eslint-plugin) from 43.0.0 to 44.0.0.
- [Release notes](https://github.com/Shopify/web-configs/releases)
- [Changelog](https://github.com/Shopify/web-configs/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/Shopify/web-configs/commits/@shopify/eslint-plugin@44.0.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@shopify/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix Record index violations

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants