Prevent bundle check from printing to stdout #942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The command
bundle check || bundle install 1>&2
only redirects the output ofbundle install
, we need parenthesis to prevent any output from going to stdout. Because it's currently printing that the dependencies are satisfied, the client incorrectly treats that as the initial handshake and the LSP can't be started.Implementation
Added parenthesis around the command.
Automated Tests
Added a test to ensure we don't regress.