-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce indexables #950
Merged
Merged
Introduce indexables #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Morriar
reviewed
Aug 30, 2023
vinistock
force-pushed
the
vs/move_prefix_tree_to_indexer
branch
from
August 30, 2023 14:44
414c102
to
35bbba0
Compare
vinistock
force-pushed
the
vs/introduce_indexables
branch
from
August 30, 2023 17:21
2a2f4fe
to
86453ce
Compare
Morriar
approved these changes
Aug 30, 2023
Morriar
reviewed
Aug 30, 2023
st0012
reviewed
Aug 31, 2023
vinistock
force-pushed
the
vs/introduce_indexables
branch
from
August 31, 2023 13:27
86453ce
to
a1aaaa0
Compare
st0012
approved these changes
Aug 31, 2023
vinistock
force-pushed
the
vs/move_prefix_tree_to_indexer
branch
2 times, most recently
from
September 1, 2023 15:56
1197e26
to
b8fb36b
Compare
vinistock
force-pushed
the
vs/introduce_indexables
branch
from
September 1, 2023 17:24
d71e2e4
to
0390299
Compare
andyw8
pushed a commit
that referenced
this pull request
Sep 5, 2023
Create Indexable as the unit of items to be indexed
vinistock
added a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
First step for #938
In order to provide require path completion through our index, we need to first remember what are the require paths for each entry. We currently only use the full path.
I think it'll be useful to have a concept of an
Indexable
as the unit of items to be indexed. In the future, if we need to include the gem name where we found an entry, we will also be able to do that.Implementation
I recommend reviewing by commit:
Indexable
Index
Automated Tests
Adapted existing tests.