Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARP Migration: Use YARP branch with column fix #956

Closed
wants to merge 2 commits into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Aug 30, 2023

Motivation

Implementation

Automated Tests

Manual Tests

@github-actions
Copy link
Contributor

Benchmark results in seconds (slowest at top)

          textDocument/completion average: 0.206052 std_dev: 0.004098
          textDocument/diagnostic average: 0.040564 std_dev: 0.010679
          textDocument/definition average: 0.004663 std_dev: 0.002752
      textDocument/selectionRange average: 0.0035 std_dev: 0.000427
   textDocument/documentHighlight average: 0.001454 std_dev: 0.000121
               codeAction/resolve average: 0.001206 std_dev: 0.000107
               textDocument/hover average: 0.001153 std_dev: 0.000117
           textDocument/inlayHint average: 0.001051 std_dev: 8.1e-05
 textDocument/semanticTokens/full average: 0.000835 std_dev: 0.000192
        textDocument/documentLink average: 0.000828 std_dev: 8.8e-05
      textDocument/documentSymbol average: 0.000828 std_dev: 6.5e-05
            textDocument/codeLens average: 0.000818 std_dev: 5.7e-05
    textDocument/onTypeFormatting average: 0.00078 std_dev: 9.0e-05
textDocument/semanticTokens/range average: 0.000776 std_dev: 8.6e-05
          textDocument/formatting average: 0.000768 std_dev: 0.000284
          textDocument/codeAction average: 0.00076 std_dev: 8.1e-05
        textDocument/foldingRange average: 0.000752 std_dev: 8.7e-05


================================================================================
Comparison with main branch:

 textDocument/semanticTokens/full faster by 66.165 %
textDocument/semanticTokens/range faster by 53.219 %
      textDocument/documentSymbol faster by 66.393 %
        textDocument/foldingRange faster by 66.896 %
          textDocument/formatting unchanged
          textDocument/diagnostic unchanged
        textDocument/documentLink faster by 66.747 %
           textDocument/inlayHint faster by 25.224 %
      textDocument/selectionRange faster by 12.488 %
   textDocument/documentHighlight faster by 42.51 %
               textDocument/hover faster by 14.925 %
          textDocument/codeAction unchanged
    textDocument/onTypeFormatting unchanged
               codeAction/resolve faster by 14.281 %
          textDocument/completion unchanged
            textDocument/codeLens faster by 67.314 %
          textDocument/definition unchanged


================================================================================
Missing benchmarks:

RubyLsp::Requests::ShowSyntaxTree

@andyw8 andyw8 closed this Sep 12, 2023
@vinistock vinistock deleted the andyw8/use-yarp-with-column-fix branch November 29, 2023 19:18
vinistock pushed a commit that referenced this pull request Feb 28, 2024
throw error if no debuggee found and remove eslint warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant