-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Spoom backtrace filter #965
Conversation
8834656
to
38567a2
Compare
Shopify/spoom#457 has been merged – I'll keep this open until it's available in the next release, then update. |
One question though, currently Spoom as a runtime dependency on We could make Spoom not depend on |
@Morriar the |
Won't you have to make Spoom a runtime dependency is you want to require some code from it? |
As long as we only require this from the tests it's okay 👍 |
067416d
to
29180eb
Compare
I don't understand why it's failing on Window...
|
29180eb
to
9a093dc
Compare
Because Spoom is not available on Windows. That will need to be a conditional require. |
9a093dc
to
f6adfc5
Compare
f6adfc5
to
acb4f28
Compare
test/test_helper.rb
Outdated
if defined? Spoom::BacktraceFilter::Minitest | ||
Minitest.backtrace_filter = Spoom::BacktraceFilter::Minitest.new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about avoiding two checks and just doing everything in the same block?
begin
require "spoom/backtrace_filter/minitest"
Minitest.backtrace_filter = Spoom::BacktraceFilter::Minitest.new
rescue LoadError
# Tapioca (and thus Spoom) is not available on Windows
end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we can do that, updated.
acb4f28
to
7093660
Compare
Motivation
Use the new Sorbet backtrace filter added in Shopify/spoom#457
Implementation
bundle update spoom
then updatetest_helper.rb
andrequire.rb
Automated Tests
n/a
Manual Tests
n/a