Use Spoom backtrace filter

[andyw8]

Motivation

Use the new Sorbet backtrace filter added in Shopify/spoom#457

Implementation

bundle update spoom then update test_helper.rb and require.rb

Automated Tests

n/a

Manual Tests

n/a

[andyw8]

Shopify/spoom#457 has been merged – I'll keep this open until it's available in the next release, then update.

[Morriar]

One question though, currently Spoom as a runtime dependency on sorbet-static, are we sure we want to import this transitive dependency to the Ruby LSP?

We could make Spoom not depend on sorbet-static in its Gemfile and just assume it would be here, but that causes problems regarding versions requirements that we would need to address first.

[andyw8]

@Morriar the spoom dependency via tapioca, which is a :development dependency in the Gemfile, so I don't think that should be a concern?

[Morriar]

Won't you have to make Spoom a runtime dependency is you want to require some code from it?

[Morriar]

As long as we only require this from the tests it's okay 👍

[andyw8]

I don't understand why it's failing on Window...

D:/a/ruby-lsp/ruby-lsp/test/test_helper.rb:15:in `require': cannot load such file -- spoom/backtrace_filter/minitest (LoadError)

[vinistock]

Because Spoom is not available on Windows. That will need to be a conditional require.

[vinistock]

How about avoiding two checks and just doing everything in the same block?

begin
  require "spoom/backtrace_filter/minitest"
  Minitest.backtrace_filter = Spoom::BacktraceFilter::Minitest.new
rescue LoadError
  # Tapioca (and thus Spoom) is not available on Windows
end

[andyw8]

Yeah we can do that, updated.