Index modules and classes starting with unicode characters #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this for now. Let's get a sense of how common it is for people to use unicode characters in their classes, modules and constants. It's probably not common enough to be worth the added complexity and performance impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ruby allows using unicode characters in constant names, so we have to account for that when indexing.
Uncovered while addressing #957 (comment).
NOTE: this PR identified a bug in YARP. It's currently ignoring the original string's encoding when doing
node.slice.Implementation
Switched the regex to allow for any uppercase character, which will include unicode ones.
Automated Tests
Added a test demonstrating some unicode character classes.