Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rephrashing GDPR terminology in Shopify/shopify-app-template-node #1302

Merged
merged 1 commit into from
Nov 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import serveStatic from "serve-static";

import shopify from "./shopify.js";
import productCreator from "./product-creator.js";
import GDPRWebhookHandlers from "./gdpr.js";
import PrivacyWebhookHandlers from "./privacy.js";

const PORT = parseInt(
process.env.BACKEND_PORT || process.env.PORT || "3000",
Expand All @@ -29,7 +29,7 @@ app.get(
);
app.post(
shopify.config.webhooks.path,
shopify.processWebhooks({ webhookHandlers: GDPRWebhookHandlers })
shopify.processWebhooks({ webhookHandlers: PrivacyWebhookHandlers })
);

// If you are adding routes outside of the /api path, remember to
Expand Down
6 changes: 3 additions & 3 deletions web/gdpr.js → web/privacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { DeliveryMethod } from "@shopify/shopify-api";
export default {
/**
* Customers can request their data from a store owner. When this happens,
* Shopify invokes this webhook.
* Shopify invokes this privacy webhook.
*
* https://shopify.dev/docs/apps/webhooks/configuration/mandatory-webhooks#customers-data_request
*/
Expand Down Expand Up @@ -38,7 +38,7 @@ export default {

/**
* Store owners can request that data is deleted on behalf of a customer. When
* this happens, Shopify invokes this webhook.
* this happens, Shopify invokes this privacy webhook.
*
* https://shopify.dev/docs/apps/webhooks/configuration/mandatory-webhooks#customers-redact
*/
Expand Down Expand Up @@ -67,7 +67,7 @@ export default {

/**
* 48 hours after a store owner uninstalls your app, Shopify invokes this
* webhook.
* privacy webhook.
*
* https://shopify.dev/docs/apps/webhooks/configuration/mandatory-webhooks#shop-redact
*/
Expand Down
Loading