Bump @shopify/eslint-plugin from 43.0.0 to 44.0.0 (#941)

* Bump @shopify/eslint-plugin from 43.0.0 to 44.0.0

Bumps [@shopify/eslint-plugin](https://github.com/Shopify/web-configs/tree/HEAD/packages/eslint-plugin) from 43.0.0 to 44.0.0.
- [Release notes](https://github.com/Shopify/web-configs/releases)
- [Changelog](https://github.com/Shopify/web-configs/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/Shopify/web-configs/commits/@shopify/eslint-plugin@44.0.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@shopify/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix Record index violations

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>

package.json

@@ -472,7 +472,7 @@
   },
   "devDependencies": {
     "@babel/core": "^7.23.6",
-    "@shopify/eslint-plugin": "^43.0.0",
+    "@shopify/eslint-plugin": "^44.0.0",
     "@shopify/prettier-config": "^1.1.2",
     "@types/glob": "^8.1.0",
     "@types/mocha": "^10.0.6",

src/client.ts

@@ -18,9 +18,7 @@ import { LOG_CHANNEL, LSP_NAME, ClientInterface } from "./common";
 import { Telemetry, RequestEvent } from "./telemetry";
 import { Ruby } from "./ruby";
 
-interface EnabledFeatures {
-  [key: string]: boolean;
-}
+type EnabledFeatures = Record<string, boolean>;
 
 // Get the executables to start the server based on the user's configuration
 function getLspExecutables(

src/rubyLsp.ts

@@ -187,15 +187,15 @@ export class RubyLsp {
             .contributes.configuration.properties["rubyLsp.enabledFeatures"]
             .properties;
 
-        const descriptions: { [key: string]: string } = {};
+        const descriptions: Record<string, string> = {};
         Object.entries(enabledFeaturesProperties).forEach(
           ([key, value]: [string, any]) => {
             descriptions[key] = value.description;
           },
         );
 
         const configuration = vscode.workspace.getConfiguration("rubyLsp");
-        const features: { [key: string]: boolean } =
+        const features: Record<string, boolean> =
           configuration.get("enabledFeatures")!;
         const allFeatures = Object.keys(features);
         const options: vscode.QuickPickItem[] = allFeatures.map((label) => {

src/status.ts

@@ -175,7 +175,7 @@ export class FeaturesStatus extends StatusItem {
 
   refresh(_workspace: WorkspaceInterface): void {
     const configuration = vscode.workspace.getConfiguration("rubyLsp");
-    const features: { [key: string]: boolean } =
+    const features: Record<string, boolean> =
       configuration.get("enabledFeatures")!;
     const enabledFeatures = Object.keys(features).filter(
       (key) => features[key],

src/test/suite/status.test.ts

@@ -209,7 +209,7 @@ suite("StatusItems", () => {
 
   suite("FeaturesStatus", () => {
     const configuration = vscode.workspace.getConfiguration("rubyLsp");
-    const originalFeatures: { [key: string]: boolean } =
+    const originalFeatures: Record<string, boolean> =
       configuration.get("enabledFeatures")!;
     const numberOfExperimentalFeatures = Object.values(originalFeatures).filter(
       (feature) => feature === false,
@@ -256,7 +256,7 @@ suite("StatusItems", () => {
         .getConfiguration("rubyLsp")
         .update("enabledFeatures", { completion: false }, true, true);
 
-      const currentFeatures: { [key: string]: boolean } = vscode.workspace
+      const currentFeatures: Record<string, boolean> = vscode.workspace
         .getConfiguration("rubyLsp")
         .get("enabledFeatures")!;
 

src/testController.ts

@@ -75,7 +75,7 @@ export class TestController {
       this.testCommands.delete(test);
     });
 
-    const groupIdMap: { [key: string]: vscode.TestItem } = {};
+    const groupIdMap: Record<string, vscode.TestItem> = {};
     let classTest: vscode.TestItem;
 
     const uri = vscode.Uri.from({

yarn.lock

@@ -467,10 +467,10 @@
     picocolors "^1.0.0"
     tslib "^2.6.0"
 
-"@shopify/eslint-plugin@^43.0.0":
-  version "43.0.0"
-  resolved "https://registry.yarnpkg.com/@shopify/eslint-plugin/-/eslint-plugin-43.0.0.tgz#6e5be2f9b063216f0d97f4424a1a7a804bd91e72"
-  integrity sha512-+/bLrmODh+OtPzf4YafsfpAbcdZfHOHBQGXgzoXPge6yUuyOo+NJiNvq0LOwo6jaRkaBgWQTUZB8HRlx4swHag==
+"@shopify/eslint-plugin@^44.0.0":
+  version "44.0.0"
+  resolved "https://registry.yarnpkg.com/@shopify/eslint-plugin/-/eslint-plugin-44.0.0.tgz#b8c45695bd88126f51b00cf6cad87a1ed6cc306d"
+  integrity sha512-p0BozXrvE7Z8EmnRJKg9QhS+8xbFPRY5u0mUFE2x8iOsSA1Yv1pGh+spR8QTz+zQCxv8DtJ0Hval9XSPFGxw4Q==
   dependencies:
     "@babel/eslint-parser" "^7.16.3"
     "@babel/eslint-plugin" "^7.14.5"