Fix Record index violations

Shopify · Dec 11, 2023 · a34e8f0 · a34e8f0
1 parent 8e3814c
commit a34e8f0
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/src/client.ts b/src/client.ts
@@ -18,9 +18,7 @@ import { LOG_CHANNEL, LSP_NAME, ClientInterface } from "./common";
 import { Telemetry, RequestEvent } from "./telemetry";
 import { Ruby } from "./ruby";
 
-interface EnabledFeatures {
-  [key: string]: boolean;
-}
+type EnabledFeatures = Record<string, boolean>;
 
 // Get the executables to start the server based on the user's configuration
 function getLspExecutables(

diff --git a/src/rubyLsp.ts b/src/rubyLsp.ts
@@ -187,15 +187,15 @@ export class RubyLsp {
             .contributes.configuration.properties["rubyLsp.enabledFeatures"]
             .properties;
 
-        const descriptions: { [key: string]: string } = {};
+        const descriptions: Record<string, string> = {};
         Object.entries(enabledFeaturesProperties).forEach(
           ([key, value]: [string, any]) => {
             descriptions[key] = value.description;
           },
         );
 
         const configuration = vscode.workspace.getConfiguration("rubyLsp");
-        const features: { [key: string]: boolean } =
+        const features: Record<string, boolean> =
           configuration.get("enabledFeatures")!;
         const allFeatures = Object.keys(features);
         const options: vscode.QuickPickItem[] = allFeatures.map((label) => {

diff --git a/src/status.ts b/src/status.ts
@@ -175,7 +175,7 @@ export class FeaturesStatus extends StatusItem {
 
   refresh(_workspace: WorkspaceInterface): void {
     const configuration = vscode.workspace.getConfiguration("rubyLsp");
-    const features: { [key: string]: boolean } =
+    const features: Record<string, boolean> =
       configuration.get("enabledFeatures")!;
     const enabledFeatures = Object.keys(features).filter(
       (key) => features[key],

diff --git a/src/test/suite/status.test.ts b/src/test/suite/status.test.ts
@@ -209,7 +209,7 @@ suite("StatusItems", () => {
 
   suite("FeaturesStatus", () => {
     const configuration = vscode.workspace.getConfiguration("rubyLsp");
-    const originalFeatures: { [key: string]: boolean } =
+    const originalFeatures: Record<string, boolean> =
       configuration.get("enabledFeatures")!;
     const numberOfExperimentalFeatures = Object.values(originalFeatures).filter(
       (feature) => feature === false,
@@ -256,7 +256,7 @@ suite("StatusItems", () => {
         .getConfiguration("rubyLsp")
         .update("enabledFeatures", { completion: false }, true, true);
 
-      const currentFeatures: { [key: string]: boolean } = vscode.workspace
+      const currentFeatures: Record<string, boolean> = vscode.workspace
         .getConfiguration("rubyLsp")
         .get("enabledFeatures")!;
 

diff --git a/src/testController.ts b/src/testController.ts
@@ -75,7 +75,7 @@ export class TestController {
       this.testCommands.delete(test);
     });
 
-    const groupIdMap: { [key: string]: vscode.TestItem } = {};
+    const groupIdMap: Record<string, vscode.TestItem> = {};
     let classTest: vscode.TestItem;
 
     const uri = vscode.Uri.from({