Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Move Dev Container hint from troubleshooting to readme #983

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Earlopain
Copy link
Contributor

Motivation

Dev Containers are great but I wasn't previously aware of them (Shopify/ruby-lsp#1303). Documentation for this already exists but not in the place I would expect it to.

Implementation

Move the text from troubleshooting to readme.
I've also added a note that only Docker is officially supported by the Dev Container extension.

@Earlopain Earlopain requested a review from a team as a code owner January 15, 2024 16:30
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@vinistock vinistock merged commit aee463c into Shopify:main Jan 16, 2024
6 checks passed
@Earlopain Earlopain deleted the docker-readme branch January 18, 2024 14:34
@connorshea
Copy link

@vinistock As part of the ruby-lsp monorepo switch, I think this bit of documentation was lost? The link that's supposed to point to container docs in TROUBLESHOOTING.md is busted now.

Could we get that fixed? :)

@vinistock
Copy link
Member

Thanks for letting us know, we indeed missed that in the migration Shopify/ruby-lsp#1890.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants