This repository has been archived by the owner on May 30, 2024. It is now read-only.
Move Dev Container hint from troubleshooting to readme #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Jan 15, 2024
Earlopain
force-pushed
the
docker-readme
branch
from
6756bb0
to
b3a691c
Compare
vinistock
approved these changes
Jan 16, 2024
|
@vinistock As part of the ruby-lsp monorepo switch, I think this bit of documentation was lost? The link that's supposed to point to container docs in TROUBLESHOOTING.md is busted now. Could we get that fixed? :) |
|
Thanks for letting us know, we indeed missed that in the migration Shopify/ruby-lsp#1890. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dev Containers are great but I wasn't previously aware of them (Shopify/ruby-lsp#1303). Documentation for this already exists but not in the place I would expect it to.
Implementation
Move the text from troubleshooting to readme.
I've also added a note that only Docker is officially supported by the Dev Container extension.