Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Remove open remote code lens related code #1016

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

snutij
Copy link
Contributor

@snutij snutij commented Feb 1, 2024

Motivation

Related to: Shopify/ruby-lsp#1344

We are moving open remote link to the hover (instead of lens now), so code related to this lens will be unused.

Implementation

Two main kinds of code:

  • code lens purely
  • configuration of code lens feature

Automated Tests

Not added, feel free to tell me if I can increase coverage somewhere. 👍

Manual Tests

See the related PR to check rendering in Gemfile. Other lenses for tests are still working.

Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll wait a couple of weeks to merge so that folks will update their servers first.

Otherwise, trying to click the code lens will result in an error saying that the command doesn't exist.

@vinistock vinistock merged commit de1b906 into Shopify:main Feb 26, 2024
6 checks passed
@Frexuz
Copy link

Frexuz commented May 1, 2024

Is this going to be released? Last release is from Feb 16th

@st0012
Copy link
Member

st0012 commented May 1, 2024

@Frexuz We've moved all the VS Code extension code and releases to https://github.com/Shopify/ruby-lsp and we're in the process of archiving this repo.

I think this feature has been released in 0.5.11 (latest is 0.5.20) but the changelog was not properly generated because it was the 1st release after the migration.

@kg-currenxie
Copy link

Ok thx :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants