This repository has been archived by the owner on May 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One thing that causes frustration is that when pulling and switching branches, we sometimes reboot the server too quickly and it results in errors or multiple unnecessary restarts.
There is also a race condition between the rebase and the lockfile watchers. If you rebase a branch and get an updated lockfile and a rebase conflict at the same exact time, there's no way to tell if which watcher will fire first. We could end up in a situation where we trigger the lockfile reboot and only after set the rebase flag to prevent further restarts, which is too late.
I think adding a debounce to our restart watchers will result in a smoother experience.
Implementation
Manual Tests