This repository has been archived by the owner on May 30, 2024. It is now read-only.
Add selection support for show syntax tree #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
vs/support_selections_in_show_ast
branch
from
b137bf8
to
9e02b07
Compare
andyw8
approved these changes
Jul 21, 2023
andyw8
pushed a commit
that referenced
this pull request
Jul 24, 2023
Add selection support for show syntax tree
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Server side PR Shopify/ruby-lsp#810
Checking the AST for the entire file is useful, but sometimes the developer might want to know only the AST for a specific selection. This PR makes our command handle the current selection to only display the AST for that part.
Implementation
Selections in VS Code use an
anchor(the initial point where the user started dragging) andactive(the final point of the selection). If nothing is selected, both still exist, but they have the exact same location.So, if
anchorandactivehave different positions, it means there's an actual selection and we can instantiate a range and send it as a request parameter.Note: if the user selects from bottom up, then the positions are inverted (
activewill happen beforeanchor). In that case,isReversedistrueand we need to account for it when instantiating the range.