-
Notifications
You must be signed in to change notification settings - Fork 52
Mention a fallback for chruby
users if project doesn't have .ruby-version
#701
Conversation
7dec123
to
bc1a396
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it makes sense to put this in a new markdown file for version managers?
Then we can aggregate all information there for different options.
Do we have information for other managers? |
There's interest from people using Something like
|
README.md
Outdated
> **Note** | ||
> | ||
> If you use `chruby` but don't have `.ruby-version` in a project, you can add `.ruby-version` to its parent folder | ||
> as a fallback. | ||
> For example, if `/projects/my_project` doesn't have `.ruby-version`, `chruby` would read `/projects/.ruby-version` instead. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this into a chruby
section in the VERSION_MANAGERS.md
file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you agree with moving the entire custom activation section there too?
Currently VERSION_MANAGERS
is an extension of it, so I feel a bit weird putting non-custom activation content here.
It'll be like
...
To make sure that the Ruby LSP can find the version manager scripts, make sure that they are loaded in the shell's
configuration script (e.g.: ~/.bashrc, ~/.zshrc) and that the SHELL environment variable is set and pointing to the
default shell.
For manager-specific notes and how to set up custom activation for managers that are not listed above, please see [version managers](VERSION_MANAGERS.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but let's at least mention custom activation in the README and link to the file, so that it's discoverable.
9ae57d9
to
7f915e9
Compare
…version` Apply suggestions from code review Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com>
f792fbf
to
2e99d17
Compare
Motivation
For
chruby
users, working on projects without.ruby-version
(e.g./ruby/irb
) would cause Ruby LSP fail to start. A workaround for that is to have.ruby-version
at a level above (e.g./ruby/.ruby-version
). But this information is not widely known.Implementation
Add note to the version manager section to explain this.