Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Avoid using --disable-gems #710

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Avoid using --disable-gems #710

merged 1 commit into from
Jul 19, 2023

Conversation

vinistock
Copy link
Member

Motivation

Closes Shopify/ruby-lsp#1641

We used --disable-gems to save a few milliseconds when invoking Ruby, but older versions won't allow you to require default gems when that flag is present.

The difference in performance is not so huge, we should definitely favour a nicer experience in this case.

Implementation

Removed usages of --disable-gems until we can show the Ruby version error.

@vinistock vinistock added the bugfix This PR will fix an existing bug label Jul 19, 2023
@vinistock vinistock added this to the 2023-Q3 milestone Jul 19, 2023
@vinistock vinistock requested a review from a team as a code owner July 19, 2023 16:32
@vinistock vinistock self-assigned this Jul 19, 2023
@vinistock vinistock requested review from andyw8 and st0012 July 19, 2023 16:32
@vinistock vinistock merged commit ea0d2f8 into main Jul 19, 2023
5 checks passed
@vinistock vinistock deleted the vs/avoid_using_disable_gems branch July 19, 2023 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix This PR will fix an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On older Rubies, VS Code extension crashes before reporting minimum required Ruby version
2 participants