This repository has been archived by the owner on May 30, 2024. It is now read-only.
Avoid running bundler commands before running custom bundle logic #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I believe these are the issues reported here #664 (comment).
We can't make any bundler inquiries before starting the server. Now that the custom bundle logic runs on the server, the bundle will only be installed after the server booted successfully. Trying to read the server version before starting will always fail if the gems aren't installed (because we haven't run bundle install yet).
Additionally, we need to fully deprecate Ruby 2.7. Because the gem now requires Ruby >=3.0, using
gem install ruby-lsp
will never installv0.7.3
, which means it's impossible to use the extension with Ruby 2.7.Implementation