This repository has been archived by the owner on May 30, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I store some of my projects in iCloud, so paths start with
~/Library/Mobile Documents/com~apple~CloudDocs
, which has a space. Without this change,getServerVersion
fails with (for example)The error shows that this is parsed as running
Documents/com~apple~CloudDocs/Projects/drjohndee.net/.ruby-lsp/Gemfile
withBUNDLE_GEMFILE=/Users/jordancole/Library/Mobile
as an environment variable.Implementation
I searched for
BUNDLE_GEMFILE
and wrapped the assignment in double quotes. It’s simplistic, but I think it's correct.Automated Tests
I haven't added tests because I'm not sure how to implement them.
Manual Tests
Client.getServerVersion
should run without error.