This repository has been archived by the owner on May 30, 2024. It is now read-only.
Add early return when shadowenv returns an empty string #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Aug 4, 2023
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
vinistock
approved these changes
Aug 4, 2023
paracycle
reviewed
Aug 4, 2023
paracycle
reviewed
Aug 4, 2023
EsterKais
approved these changes
Aug 7, 2023
bitwise-aiden
force-pushed
the
bitwise-aiden/shadow-env-return
branch
from
3128c90
to
d192156
Compare
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
bitwise-aiden
force-pushed
the
bitwise-aiden/shadow-env-return
branch
from
d192156
to
fe4aff1
Compare
vinistock
approved these changes
Aug 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Raised by @EsterKais, shadowenv has been failing because we are expecting
shadowenv hook --jsonto return valid json. It is possible that this command won't print anything to stdout which will result in an empty string instead.Implementation
Check command output, returning early if it is empty.