Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Add early return when shadowenv returns an empty string #735

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

bitwise-aiden
Copy link
Contributor

Motivation

Raised by @EsterKais, shadowenv has been failing because we are expecting shadowenv hook --json to return valid json. It is possible that this command won't print anything to stdout which will result in an empty string instead.

Implementation

Check command output, returning early if it is empty.

@bitwise-aiden bitwise-aiden requested a review from a team as a code owner August 4, 2023 18:02
src/ruby.ts Outdated Show resolved Hide resolved
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
src/ruby.ts Outdated Show resolved Hide resolved
src/ruby.ts Outdated Show resolved Hide resolved
@bitwise-aiden bitwise-aiden force-pushed the bitwise-aiden/shadow-env-return branch from 3128c90 to d192156 Compare August 8, 2023 14:27
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
@vinistock vinistock added the bugfix This PR will fix an existing bug label Aug 8, 2023
@vinistock vinistock merged commit 7229a9e into main Aug 8, 2023
5 checks passed
@vinistock vinistock deleted the bitwise-aiden/shadow-env-return branch August 8, 2023 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix This PR will fix an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants