This repository has been archived by the owner on May 30, 2024. It is now read-only.
Warn users if no lockfile is detected on the configured workspace #945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes Shopify/ruby-lsp#1691, closes Shopify/ruby-lsp#1693
The change to support multi-root workspaces is causing some confusion for users. Previously, because we always activated the LSP on the first workspace folder entry, the LSP would "work" even in a monorepo without proper multi-root configuration. It would not find the bundle and then just start as if you had none.
Now, with adequate multi-root support, we don't activate if the workspace doesn't include a bundle. We can do better to direct users into applying the proper configurations.
Implementation
My proposed solution is to show a warning when we try to activate the LSP in a workspace that doesn't contain a bundle, allowing the user to take 3 actions: