This repository has been archived by the owner on May 30, 2024. It is now read-only.
Only show lockfile warning on lazy activation #971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are two types of workspace activation: eager or lazy.
Eager happens when we activate the extension. We check to see if there's a lockfile in the workspace root and then proceed to activate. Lazy happens when a Ruby document is opened in a workspace we had not activated before.
Currently, we're showing the lockfile warning on both, which is a poor experience. We should really only show it on lazy activations, giving the chance to the user to do something about it.
But if the workspace is not a Ruby workspace, then we shouldn't show it and should just default to not starting the LSP.
Implementation
This PR makes a few tweaks to the experience: