This repository has been archived by the owner on May 30, 2024. It is now read-only.
Save workspace folder instead of custom workspace object in debug config #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes Shopify/ruby-lsp#1676
In #976, we started saving our custom
Workspace
objects into the debugging session configuration.I remember testing this and it working, but I might be misremembering. It indeed causes the strange issue reported in Shopify/ruby-lsp#1676, which just opens the
launch.json
file instead of launching the debugger.I tried step debugging and it leads inside VS Code internals in some serialization code. My assumption is that it serializes the configuration and something fails because our custom object must not conform to whatever interface is needed to serialize/deserialize.
Implementation
We only need the workspace folder, so let's save only that in the configuration.
Manual Tests
launch.json
file