Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yellow/Grey Buffer Lines Improvements #492

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

sophiabeluli
Copy link
Member

  • use estimated time countdown to predict where bit is and therefore where greyed lines should be

@kglovern
Copy link
Member

This looks good when starting a job normally, but when using start-from-line the behaviour is not as expected.

Test file: MB-3.1

Start from line: 75000 / 150500

You'll notice half the file becomes yellow lines (planned) but the grey lines start from the origin.

Expected behaviour is that the first 75000 lines would be greyed out and planned lines would start from there.
Uploading Screenshot 2024-03-27 at 3.37.11 PM.png…

@kglovern
Copy link
Member

kglovern commented Apr 3, 2024

This crashes the renderer when a job is run twice in a row.

Tested using jsdc fixture.

image

@kglovern kglovern merged commit 2659b7f into master Apr 10, 2024
3 checks passed
@kglovern kglovern deleted the MI-1373-Yellow-Buffer-Improvements branch July 17, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants