From ba7343be8fa3f3dfbcfafc3b718b7b7259899f5b Mon Sep 17 00:00:00 2001 From: Shaheer Kochai Date: Wed, 4 Sep 2024 18:16:44 +0430 Subject: [PATCH] Fix: UI feedback changes (#5852) * fix: add divider before delete button * fix: timeline section title color in lightmode * fix: remove the extra border from alert history tabs --- .../container/AlertHistory/Timeline/Timeline.styles.scss | 8 ++++++++ frontend/src/pages/AlertDetails/AlertDetails.styles.scss | 2 +- .../AlertHeader/ActionButtons/ActionButtons.tsx | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/frontend/src/container/AlertHistory/Timeline/Timeline.styles.scss b/frontend/src/container/AlertHistory/Timeline/Timeline.styles.scss index df5875403c..1d6b4d7990 100644 --- a/frontend/src/container/AlertHistory/Timeline/Timeline.styles.scss +++ b/frontend/src/container/AlertHistory/Timeline/Timeline.styles.scss @@ -12,3 +12,11 @@ letter-spacing: -0.07px; } } + +.lightMode { + .timeline { + &__title { + color: var(--text-ink-400); + } + } +} diff --git a/frontend/src/pages/AlertDetails/AlertDetails.styles.scss b/frontend/src/pages/AlertDetails/AlertDetails.styles.scss index 10e8e573cf..62eeb96ae0 100644 --- a/frontend/src/pages/AlertDetails/AlertDetails.styles.scss +++ b/frontend/src/pages/AlertDetails/AlertDetails.styles.scss @@ -171,7 +171,7 @@ .ant-tabs { &-nav { &::before { - border-bottom: 1px solid var(--bg-vanilla-300) !important; + border: none !important; } } &-tab { diff --git a/frontend/src/pages/AlertDetails/AlertHeader/ActionButtons/ActionButtons.tsx b/frontend/src/pages/AlertDetails/AlertHeader/ActionButtons/ActionButtons.tsx index 183b4d2aaa..186a34676b 100644 --- a/frontend/src/pages/AlertDetails/AlertHeader/ActionButtons/ActionButtons.tsx +++ b/frontend/src/pages/AlertDetails/AlertHeader/ActionButtons/ActionButtons.tsx @@ -63,6 +63,7 @@ function AlertActionButtons({ onClick: (): void => handleAlertDuplicate(), style: menuItemStyle, }, + { type: 'divider' }, { key: 'delete-rule', label: 'Delete',