fix: use severity_number to determine severity_text_type #4694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
|
|
|
Hello, I would solve this issue differently. I would use the |
|
@srikanthccv I fully agree that would be a better solution, I'll adjust the PR. |
…aikhlin/signoz into feautre/dot-net-loglevels
DanikRaikhlin
changed the title
|
PR updated to use severity_number |
|
LGTM, i'll let the owners of the code review it. |
…aikhlin/signoz into feautre/dot-net-loglevels
…aikhlin/signoz into feautre/dot-net-loglevels
DanikRaikhlin
changed the title
|
@srikanthccv is there something I can do to progress the PR or is this PR not desired? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add .NET notations for SEVERITY_TEXT_TYPE and use them to fix log level coloring.
Related Issues / PR's
Issue : #4693
Screenshots