-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Logs new schema support #5528
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
I have added a description of how to go about the PR, let me know if a walkthrough is required. |
Even with a walkthrough, I won't be able to review this (I made a couple of attempts to skim through but it's too big to comprehend). It is 4k+ additions. Please send them in multiple stacked PRs. |
Sure, I will try to break it down. |
2d5de4d
to
fe63c3d
Compare
PR for new logs schema
Fixes #5555
current limitations
How to go about this PR
Section 1:- Logs v3 and v4 builder
Section 2:- The materialize api's and attribute api's in reader.go
Section 3:-
runLogsListQuery
in querier.goWe have updated the logs on how list data is fetched for logs, first we check the last 30 mins data to find the 100 logs and then increase the window size until 100 logs are found.
Section 4: - Use of the useLogsNewSchema flag.
Changes to different files are added just so that useLogsNewSchema can be passed around.