fix: colored logs in new logs explorer #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
nityanandagohain
previously approved these changes
Aug 22, 2024
YounixM
reviewed
Aug 22, 2024
YounixM
reviewed
Aug 22, 2024
YounixM
reviewed
Aug 22, 2024
YounixM
previously approved these changes
Aug 22, 2024
vikrantgupta25
force-pushed
the
logs-explorer-colored-logs
branch
from
86002cd to
d6fb3c4
Compare
YounixM
approved these changes
Aug 22, 2024
SagarRajput-7
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR takes care of
unescapingthe characters in the logs view where in some receivers ( ex - file log ) the special characters were auto escaped hence no color was being rendered despite the ansi codes being present.The same thing has been done for the logs detail view as well where the body can be seen to be rendered with proper colors.
Also this takes care of removing all the escaped characters while rendering the same in tooltip and body column
Related Issues / PR's
contributes to - https://github.com/SigNoz/engineering-pod/issues/1622
fixes - #4139
Screenshots
Screen.Recording.2024-08-22.at.4.24.07.PM.mov