-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: group by severity logs explorer page by default #5772
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Please report the perf impact on scanning 50M or 100M rows |
https://www.notion.so/signoz/group-by-severity_text-78339feea9914f1c839f01f999904ad9 added the cases for 100M and 450M here. |
This is only relevant when the groupby is |
I am still of the opinion of showing legends of different |
Also, a loom along with the PR helps a lot in seeing visual changes and 1st set of feedbacks without needing to run the PR |
The frequency chart has a fixed group by of
We can do the same, also on the hover of the graph you will be able to see the details of label and the corresponding color.
yes i just removed the older video and was about to add the updated changes video soon before sharing it in channel 😅 |
Looks good to me @vikrantgupta25 |
will it help the user in some way when they are already doing groupby some other field ? |
done @nityanandagohain , added back the legends as well to make sure users don't get confused due to no standard color encodings. |
Summary
Related Issues / PR's
fixes #4727
Screenshots
Screen.Recording.2024-09-12.at.12.52.31.PM.mov
Affected Areas and Manually Tested Areas