Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group by severity logs explorer page by default #5772

Merged
merged 16 commits into from
Sep 13, 2024

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Aug 26, 2024

Summary

  • the list view has by default group by of severity text for frequency chart.
  • no change in any other existing behavviour

Related Issues / PR's

fixes #4727

Screenshots

Screen.Recording.2024-09-12.at.12.52.31.PM.mov

Affected Areas and Manually Tested Areas

  • Logs Explorer Views Chart
  • Live Logs Chart

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Aug 26, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ankitnayan
Copy link
Collaborator

Please report the perf impact on scanning 50M or 100M rows

@vikrantgupta25 vikrantgupta25 changed the title feat: initial setup for group by severity logs explorer page feat: group by severity logs explorer page by default Aug 26, 2024
@vikrantgupta25
Copy link
Collaborator Author

Please report the perf impact on scanning 50M or 100M rows

https://www.notion.so/signoz/group-by-severity_text-78339feea9914f1c839f01f999904ad9 added the cases for 100M and 450M here.

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review September 10, 2024 18:58
@ankitnayan
Copy link
Collaborator

no legends for the logs explorer frequency chart as the colors are self explanatory.

This is only relevant when the groupby is severity_text. The legends are important if the groupby clause is something else like k8s.deployment.name

@ankitnayan
Copy link
Collaborator

I am still of the opinion of showing legends of different severity_text as there is no coloring convention and users might get confused with warning, debug and error, fatal categories.

@ankitnayan
Copy link
Collaborator

Also, a loom along with the PR helps a lot in seeing visual changes and 1st set of feedbacks without needing to run the PR

@vikrantgupta25
Copy link
Collaborator Author

vikrantgupta25 commented Sep 11, 2024

This is only relevant when the groupby is severity_text. The legends are important if the groupby clause is something else like k8s.deployment.name

The frequency chart has a fixed group by of severity_text always hence no legends for the same.

I am still of the opinion of showing legends of different severity_text as there is no coloring convention and users might get confused with warning, debug and error, fatal categories.

We can do the same, also on the hover of the graph you will be able to see the details of label and the corresponding color.

Also, a loom along with the PR helps a lot in seeing visual changes and 1st set of feedbacks without needing to run the PR

yes i just removed the older video and was about to add the updated changes video soon before sharing it in channel 😅

@GeekBoySupreme
Copy link
Collaborator

Looks good to me @vikrantgupta25

@nityanandagohain
Copy link
Member

The where clause and all the filters for the lower graph are picked and aggregateOperator and groupBy are overridden by Count and SeverityText respectively

will it help the user in some way when they are already doing groupby some other field ?
We can keep this functionality limited to the list view ?

@vikrantgupta25
Copy link
Collaborator Author

We can keep this functionality limited to the list view ?

done @nityanandagohain , added back the legends as well to make sure users don't get confused due to no standard color encodings.

@vikrantgupta25 vikrantgupta25 merged commit 43577c7 into develop Sep 13, 2024
12 of 13 checks passed
@vikrantgupta25 vikrantgupta25 deleted the group-by-severity branch September 13, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOGS: Update histogram to show logs by severity
5 participants