-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client side query builder search #5891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
frontend/src/components/ClientSideQBSearch/ClientSideQBSearchDropdown.tsx
Outdated
Show resolved
Hide resolved
ahmadshaheer
force-pushed
the
feat/client-side-query-builder-search
branch
from
September 25, 2024 10:07
3b78d09
to
9e23860
Compare
YounixM
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmadshaheer Can you check why the build is failing?
Rest LGTM.
rahulkeswani101
previously approved these changes
Oct 1, 2024
SagarRajput-7
previously approved these changes
Oct 3, 2024
ahmadshaheer
dismissed stale reviews from SagarRajput-7 and rahulkeswani101
via
October 8, 2024 11:37
499e1e3
ahmadshaheer
force-pushed
the
feat/client-side-query-builder-search
branch
from
October 8, 2024 11:37
92b48a1
to
499e1e3
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
SagarRajput-7
approved these changes
Oct 8, 2024
rahulkeswani101
approved these changes
Oct 8, 2024
YounixM
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
build client-side search with features of Query Builder, it can accept predefined keys and values
Related Issues / PR's
Screenshots
with
attributeKeys
only:https://www.loom.com/share/6beeb6ea1a514ec484ecba40bfda6c46
with
attributeKeys
andattributeValuesMap
https://www.loom.com/share/2d5b781fdefd4c4ea9f623f1a40da50b
Affected Areas and Manually Tested Areas