Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client side query builder search #5891

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Sep 8, 2024

Summary

build client-side search with features of Query Builder, it can accept predefined keys and values

Related Issues / PR's

Screenshots

with attributeKeys only:
https://www.loom.com/share/6beeb6ea1a514ec484ecba40bfda6c46

with attributeKeys and attributeValuesMap
https://www.loom.com/share/2d5b781fdefd4c4ea9f623f1a40da50b

Affected Areas and Manually Tested Areas

  • Alert history page

Copy link

github-actions bot commented Sep 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Sep 8, 2024
@ahmadshaheer ahmadshaheer force-pushed the feat/client-side-query-builder-search branch from 3b78d09 to 9e23860 Compare September 25, 2024 10:07
Copy link
Contributor

@rahulkeswani101 rahulkeswani101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmadshaheer Can you check why the build is failing?
Rest LGTM.

rahulkeswani101
rahulkeswani101 previously approved these changes Oct 1, 2024
@ahmadshaheer ahmadshaheer requested a review from YounixM October 1, 2024 07:46
SagarRajput-7
SagarRajput-7 previously approved these changes Oct 3, 2024
@ahmadshaheer ahmadshaheer force-pushed the feat/client-side-query-builder-search branch from 92b48a1 to 499e1e3 Compare October 8, 2024 11:37
Copy link

github-actions bot commented Oct 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ahmadshaheer ahmadshaheer merged commit f1ce82a into develop Oct 9, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants