Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added global search on table panel #5893

Merged
merged 9 commits into from
Sep 20, 2024
Merged

feat: added global search on table panel #5893

merged 9 commits into from
Sep 20, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Sep 8, 2024

Summary

Related Issues / PR's

Screenshots

Screenshot 2024-09-13 at 10 42 52 AM Screenshot 2024-09-13 at 10 43 00 AM Screenshot 2024-09-13 at 10 22 52 AM Screenshot 2024-09-13 at 10 23 08 AM

Affected Areas and Manually Tested Areas

Copy link

github-actions bot commented Sep 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Sep 8, 2024
@srikanthccv srikanthccv self-requested a review September 9, 2024 03:28
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25
Copy link
Collaborator

should be a good time to start adding test cases as well with PR ? as we are and will be making a bunch of changes to these components in coming times.

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YounixM
Copy link
Member

YounixM commented Sep 20, 2024

@SagarRajput-7 : as we are fixing the component, can we fix the spacing at the bottom too.. it doesn't look clean.

Feel free to create another ticket and pick it separately

@SagarRajput-7 SagarRajput-7 merged commit cb1cd35 into develop Sep 20, 2024
12 of 13 checks passed
@SagarRajput-7 SagarRajput-7 deleted the SIG-5260 branch September 20, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants