Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate V4 QB #5914

Merged
merged 27 commits into from
Sep 13, 2024
Merged

Integrate V4 QB #5914

merged 27 commits into from
Sep 13, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Sep 10, 2024

Follow up of #5912 . This PR contains changes of #5912 as well. So please review it first before coming to this PR.

For issue #5555

Here the different API's are configured to use the new schema in a feature flag.

  • GetLogFields() use the new table if flag is enabled.
  • UpdateLogField() uses the new table if flag is enabled ( selected field api)
  • GetLogAggregateAttributes() uses the new table if flag is enabled.
  • GetLogAttributeKeys() uses the new table if flag is enabled.
  • GetLogAttributeValues() uses the new table if flag is enabled.
  • LiveTailLogsV4() is used if flag is enabled else LiveTailV3
  • Query Builder options is moved to model.

@nityanandagohain nityanandagohain marked this pull request as ready for review September 12, 2024 09:05
@srikanthccv
Copy link
Member

Whereever there are big functions, can you make a v2 version of it and call it at the start of call chain instead of if use { a lot new schema code} else {lot of old code}

  • It will be easier to follow the changes in PR because you won't touch old code
  • it will be easier to delete when the v2 rollout is complete

@nityanandagohain
Copy link
Member Author

Thanks for the feedback, it makes sense. Let me do that.

@nityanandagohain nityanandagohain merged commit 011b216 into develop Sep 13, 2024
13 checks passed
@nityanandagohain nityanandagohain deleted the feat/integrate-v4-qb branch September 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants