Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: anomaly detection UI #5916

Merged
merged 8 commits into from
Oct 14, 2024
Merged

feat: anomaly detection UI #5916

merged 8 commits into from
Oct 14, 2024

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Sep 10, 2024

Feature: Anomal Detection

Users should be able to setup a anomaly based alerts for metrics.

Alert Selection Change
Screenshot 2024-10-13 at 5 35 00 PM

Switch between Threshold based alert and Anomaly based alert
Screenshot 2024-10-13 at 5 35 11 PM

Define Alert Section Change:
Screenshot 2024-10-13 at 5 35 21 PM

Evaluation view rendering
Screenshot 2024-10-13 at 5 35 52 PM

Screenshot 2024-10-13 at 5 36 26 PM Screenshot 2024-10-13 at 5 36 47 PM

Anomaly Function for all queries
Screenshot 2024-10-13 at 5 37 05 PM

Copy link

request-info bot commented Sep 10, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Sep 10, 2024
@YounixM YounixM force-pushed the anamoly-detection-ui branch from fc223fe to 9e6a0af Compare September 10, 2024 20:22
@YounixM YounixM force-pushed the anamoly-detection-ui branch from 9e6a0af to 486798d Compare October 13, 2024 09:18
@YounixM YounixM changed the title feat: anomaly detection - initial ui feat: anomaly detection UI Oct 13, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM YounixM requested a review from srikanthccv October 13, 2024 11:57
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM
Copy link
Member Author

YounixM commented Oct 13, 2024

@vikrantgupta25 : Will take these up in the subsequent PR's.

@srikanthccv srikanthccv self-assigned this Oct 13, 2024
@srikanthccv
Copy link
Member

  • Let's add a beta tag for this
  • This is an EE feature so we should only show when ANOMALY_DETECTION is enabled
  • Can we make the graph experience the same as the rest of the product? The mouse movement on the graph has a completely different experience.
  • We should add a simple search for legend selection since the list can be too long
  • The lower band and upper band have straight lines even when the data has variation, the real and predicted lines are fine.
  • There can only be one active query on the graph, which should be the same as the selected query condition. The data for other queries should not be shown
  • We need to figure out a few things related to the formula (since there are no functions in the formula, nothing is shown)

@YounixM
Copy link
Member Author

YounixM commented Oct 14, 2024

@srikanthccv

Can we make the graph experience the same as the rest of the product? The mouse movement on the graph has a completely different experience.

Will make the change in the next PR.

Can you please provide more details on these points

There can only be one active query on the graph, which should be the same as the selected query condition. The data for other queries should not be shown
We need to figure out a few things related to the formula (since there are no functions in the formula, nothing is shown)

@YounixM
Copy link
Member Author

YounixM commented Oct 14, 2024

@srikanthccv : Will the API return only the non anomaly based alerts if the FF is disabled ? How do we want to handle this ?

@srikanthccv
Copy link
Member

Discussed disabling the anomaly detection by default for everyone and only enable for specific tenants (like private beta), starting with saasmonitor.

@YounixM
Copy link
Member Author

YounixM commented Oct 14, 2024

As discussed, merging the base PR. will work on the above points in next PR / subsequent PR's

@YounixM YounixM merged commit 2180118 into develop Oct 14, 2024
12 of 14 checks passed
@YounixM
Copy link
Member Author

YounixM commented Oct 14, 2024

  1. Let's add a beta tag for this
  2. This is an EE feature so we should only show when ANOMALY_DETECTION is enabled

Merged ✅

@YounixM
Copy link
Member Author

YounixM commented Oct 14, 2024

  1. We should add a simple search for legend selection since the list can be too long - PR raised

@YounixM
Copy link
Member Author

YounixM commented Oct 15, 2024

  1. We should add a simple search for legend selection since the list can be too long - PR merged ✅

  2. Added tooltip to show series data. - PR raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request request-more-info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants