-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add drag support to alert history horizontal graph #5928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
@ahmadshaheer : have we tested that if this affects other areas where we use uPlot ? |
@YounixM, I have made these changes to the timeline graph component of alert history. it is not going to affect any other areas. |
SagarRajput-7
previously approved these changes
Sep 26, 2024
vikrantgupta25
previously approved these changes
Sep 26, 2024
ahmadshaheer
dismissed stale reviews from vikrantgupta25 and SagarRajput-7
via
September 27, 2024 07:43
7f68089
…selected time range
YounixM
approved these changes
Sep 30, 2024
rahulkeswani101
approved these changes
Sep 30, 2024
SagarRajput-7
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
close #5921
Screenshots
https://us04web.zoom.us/clips/share/WeYNubDhLjZvfaX_Rdwh2aQce878hy9gtvjh5MuXaMe3-4V3ysHssXTnihzCLJwD0MqEArOjCpNvDgDaaql8nEdv-w.XQsJltp4tI0MiHtY
Affected Areas and Manually Tested Areas