-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add expand/collapse button to the top in trace details #5980
Merged
ahmadshaheer
merged 3 commits into
develop
from
feat/add-expand-collapase-button-to-the-top-in-trace-details
Oct 1, 2024
Merged
feat: add expand/collapse button to the top in trace details #5980
ahmadshaheer
merged 3 commits into
develop
from
feat/add-expand-collapase-button-to-the-top-in-trace-details
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YounixM
previously approved these changes
Sep 24, 2024
YounixM
force-pushed
the
feat/add-expand-collapase-button-to-the-top-in-trace-details
branch
from
September 24, 2024 18:27
e800e89
to
8e70bb4
Compare
SagarRajput-7
previously approved these changes
Sep 26, 2024
@ahmadshaheer build is failing ... |
vikrantgupta25
previously approved these changes
Sep 26, 2024
ahmadshaheer
dismissed stale reviews from vikrantgupta25, SagarRajput-7, and YounixM
via
September 27, 2024 14:33
b0fa464
There was a failing test, @vikrantgupta25 , I fixed it. but I get this error in Jest Coverage: |
YounixM
approved these changes
Sep 30, 2024
rahulkeswani101
approved these changes
Sep 30, 2024
SagarRajput-7
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
close https://github.com/SigNoz/engineering-pod/issues/1439
Screenshots
Before:
After:
Dark:
Light:
Affected Areas and Manually Tested Areas