Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expand/collapse button to the top in trace details #5980

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Sep 15, 2024

Summary

Related Issues / PR's

close https://github.com/SigNoz/engineering-pod/issues/1439

Screenshots

Before:

Screenshot from 2024-09-15 19-12-37
Screenshot from 2024-09-15 19-12-31

After:

Dark:
Screenshot from 2024-09-15 19-10-20
Screenshot from 2024-09-15 19-10-15

Light:
Screenshot from 2024-09-15 19-09-52
Screenshot from 2024-09-15 19-09-47

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Sep 15, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

YounixM
YounixM previously approved these changes Sep 24, 2024
@YounixM YounixM force-pushed the feat/add-expand-collapase-button-to-the-top-in-trace-details branch from e800e89 to 8e70bb4 Compare September 24, 2024 18:27
SagarRajput-7
SagarRajput-7 previously approved these changes Sep 26, 2024
@vikrantgupta25
Copy link
Collaborator

@ahmadshaheer build is failing ...

vikrantgupta25
vikrantgupta25 previously approved these changes Sep 26, 2024
@ahmadshaheer
Copy link
Collaborator Author

@ahmadshaheer build is failing ...

There was a failing test, @vikrantgupta25 , I fixed it. but I get this error in Jest Coverage:

Screenshot from 2024-09-27 12-29-01

@ahmadshaheer ahmadshaheer merged commit 266ed58 into develop Oct 1, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants